feat: filter out private and loopback addresses #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
force-pushed
the
sanitize-router
branch
from
13432c7
to
0a9f117
Compare
hacdias
commented
Mar 27, 2024
Comment on lines
+420
to
+422
| type sanitizeRouter struct { | ||
| router | ||
| } |
There was a problem hiding this comment.
The other option is to apply filterPrivateMultiaddr directly in libp2pRouter, and the iter.Maps in clientRouter.
aschmahmann
reviewed
Apr 11, 2024
aschmahmann
approved these changes
Apr 11, 2024
|
@hacdias What's the best way to track whether changes to Someguy have been deployed yet to the hosted delegated routing endpoint? |
|
@2color you can check the version here: https://delegated-ipfs.dev/version - albeit it seems off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28.