Skip to content

DAG Import/Export #7011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ribasushi wants to merge 17 commits into from
Closed

DAG Import/Export #7011

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
aa50194
Dag import/export for final review: full sharness battery coming Sat.
ribasushi Mar 4, 2020
1997ac9
Update core/commands/dag/dag.go
ribasushi Mar 21, 2020
55d1413
Errors are not serialized to JSON - use strings
ribasushi Mar 21, 2020
fccbd8f
Do not listen to nonexistent timers when progress disabled
ribasushi Mar 21, 2020
1a2cf9f
Only allow progress on the CLI
ribasushi Mar 21, 2020
0fe70a6
Stop variable/type shadowing
ribasushi Mar 21, 2020
7b48943
Clarify iterator file closures
ribasushi Mar 21, 2020
ae2d4f7
switch channel to context
willscott Mar 21, 2020
aa85f2e
Properly exit with an error if some pins fail
ribasushi Mar 23, 2020
de52029
Streamline progress/silence/tty defaulting
ribasushi Mar 24, 2020
67642d8
Fix importer progress display:
ribasushi Mar 23, 2020
3d9ed1a
Fix exporter progress display
ribasushi Mar 24, 2020
b613246
Temporarily back out use of go-ipld-prime
ribasushi Mar 24, 2020
752073b
Initial 'happy path' sharness test
ribasushi Mar 25, 2020
0dae3a2
Augment tests to show pinning/gc troubles
ribasushi Mar 25, 2020
03fe9bd
Merge remote-tracking branch 'origin/master' into feat/carfile-support
ribasushi Mar 25, 2020
e8540c6
Forgotten backed out piece from go-ipld-prime codepath
ribasushi Mar 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/commands/dag/dag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,11 @@ pin each individual root specified in the car headers, before GC runs again.
cmds.BoolOption(pinRootsOptionName, "Pin optional roots listed in the .car headers after importing.").WithDefault(true),
},
PreRun: func(req *cmds.Request, env cmds.Environment) error {
if silent, _ := req.Options[silentOptionName].(bool); silent {
silent, _ := req.Options[silentOptionName].(bool)
encType, _ := req.Options[cmds.EncLong].(string)

// force-disable progress unless on non-silent CLI
if silent || encType != "text" {
req.Options[progressOptionName] = false
Copy link
Member

@Stebalien Stebalien Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I ask for progress but set the encoding type to json, I'd expect json progress updates. I wouldn't mess with this in pre-run.

}

Expand Down