Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/macos sharness fixes #6988

Merged
merged 3 commits into from
Mar 12, 2020
Merged

Chore/macos sharness fixes #6988

merged 3 commits into from
Mar 12, 2020

Commits on Mar 12, 2020

  1. Require go 1.14 

    A dependency of ours now requires 1.14, let's be more explicit ourselves

../../go/pkg/mod/github.com/lucas-clemente/[email protected]/interface.go:54:2: duplicate method StreamID
../../go/pkg/mod/github.com/lucas-clemente/[email protected]/stream.go:44:2: duplicate method StreamID
note: module requires Go 1.14
    @ribasushi
    ribasushi committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    0819fe6 View commit details
    Browse the repository at this point in the history

  2. Prevent go fmt check from failing under make -j10 test 

    Under high paralellism we would be regenerating the plugin source
while doing the initial `go fmt` read.

Instead simply exclude the generated file.
    @ribasushi
    ribasushi committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    81cb535 View commit details
    Browse the repository at this point in the history

  3. Simplify grep in test to pass on MacOS

    @ribasushi
    ribasushi committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    7b65c07 View commit details
    Browse the repository at this point in the history