Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing EncodedFSKeystore with base32 encoding (#5947) #6955

Merged
merged 3 commits into from
Mar 24, 2020

Conversation

hsanjuan
Copy link
Contributor

@hsanjuan hsanjuan commented Mar 5, 2020

Ported from #6012


Encoding the key's filename with base32 introduces coherent behaviour
across different platforms and their case-sensitive/case-insensitive
file-systems. Moreover it allows wider character set to be used for the
name of the keys as the original restriction for special FS's characters
(e.g. '/', '.') will not apply.

License: MIT
Signed-off-by: Adam Uhlir [email protected]

@hsanjuan
Copy link
Contributor Author

hsanjuan commented Mar 5, 2020

Ready on my side, I made minor changes over what was already approved. I tagged a test version and built a custom dist release so that it can be tested with https://github.com/ipfs/fs-repo-migrations/pull/96/files

keystore/keystore.go Outdated Show resolved Hide resolved
keystore/keystore.go Outdated Show resolved Hide resolved
keystore/keystore.go Outdated Show resolved Hide resolved
keystore/keystore.go Outdated Show resolved Hide resolved
keystore/keystore.go Outdated Show resolved Hide resolved
@Stebalien Stebalien force-pushed the feat/AuHau-encoding-key-names branch from 5f38c18 to 060cdab Compare March 14, 2020 02:45
keystore/keystore.go Outdated Show resolved Hide resolved
@hsanjuan hsanjuan requested a review from Stebalien March 15, 2020 22:19
@hsanjuan hsanjuan force-pushed the feat/AuHau-encoding-key-names branch from 13f0c20 to cbb4017 Compare March 16, 2020 16:37
@hsanjuan
Copy link
Contributor Author

@Stebalien I have squashed the commit history.

However we need to merge ipfs/fs-repo-migrations#96 and release fs-repo-migrations before proceeding here.

@Stebalien Stebalien mentioned this pull request Mar 16, 2020
21 tasks
@Stebalien
Copy link
Member

I've cut a release: ipfs/distributions#285.

@Stebalien
Copy link
Member

(well, I haven't published it yet but I figured we should test it first)

AuHau and others added 2 commits March 23, 2020 17:05
Encoding the key's filename with base32 introduces coherent behaviour
across different platforms and their case-sensitive/case-insensitive
file-systems. Moreover it allows wider character set to be used for the
name of the keys as the original restriction for special FS's characters
(e.g. '/', '.') will not apply.

License: MIT
Signed-off-by: Adam Uhlir <[email protected]>
* Use Go's base32 library
* Set repo to version 9
* Resolve linting problems and docs.
* Merge EncodedFSKeystore into FSKeystore
* Remove name limitations and adjust tests
@Stebalien Stebalien force-pushed the feat/AuHau-encoding-key-names branch from cbb4017 to 2a27519 Compare March 24, 2020 00:40
@Stebalien Stebalien force-pushed the feat/AuHau-encoding-key-names branch from 2a27519 to 0d9d6e9 Compare March 24, 2020 00:46
@Stebalien Stebalien merged commit efe6ef9 into master Mar 24, 2020
@hacdias hacdias deleted the feat/AuHau-encoding-key-names branch May 9, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants