Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6878: Improve MFS Cli documentation #6882

Merged
merged 5 commits into from
Feb 7, 2020
Merged

Fix #6878: Improve MFS Cli documentation #6882

merged 5 commits into from
Feb 7, 2020

Conversation

hsanjuan
Copy link
Contributor

@hsanjuan hsanjuan commented Feb 7, 2020

No description provided.

@hsanjuan hsanjuan self-assigned this Feb 7, 2020
@hsanjuan hsanjuan mentioned this pull request Feb 7, 2020
Closed
mohe2015
mohe2015 reviewed Feb 7, 2020
View reviewed changes
core/commands/files.go Outdated Show resolved Hide resolved
@RubenKelevra
Copy link
Contributor

Nice!

But it's missing the information that content can be pinned and part of the MFS, so deleting pinned files and folders won't release the pin and therefore not release the storage for GC. :)

@hsanjuan
Copy link
Contributor Author

hsanjuan commented Feb 7, 2020

Nice!

But it's missing the information that content can be pinned and part of the MFS, so deleting pinned files and folders won't release the pin and therefore not release the storage for GC. :)

Calls to "ipfs pin add" and "ipfs pin rm" do not affect content on MFS. isn't this exactly that?

@RubenKelevra
Copy link
Contributor

Maybe:

Calls to "ipfs pin add" and "ipfs pin rm" will add and remove an additionally pin on the content on MFS. If pinned MFS content is removed by calling "ipfs files rm", it will remain pinned.

Stebalien
Stebalien approved these changes Feb 7, 2020
View reviewed changes
core/commands/files.go Outdated Show resolved Hide resolved
RubenKelevra
RubenKelevra approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@RubenKelevra RubenKelevra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sounded pretty strange TBH!

@hsanjuan hsanjuan merged commit 8e9725f into master Feb 7, 2020
@hsanjuan hsanjuan deleted the fix/6878-mfs-docs branch February 7, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohe2015 mohe2015 mohe2015 left review comments

@Stebalien Stebalien Stebalien approved these changes

@RubenKelevra RubenKelevra RubenKelevra approved these changes

Assignees

@hsanjuan hsanjuan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsanjuan @RubenKelevra @Stebalien @mohe2015