Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DontCheckOSXFUSE config command example #5951

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

da2x
Copy link
Contributor

@da2x da2x commented Jan 28, 2019

Partial fix for #5317.

License: MIT
Signed-off-by: Daniel Aleksandersen

License: MIT
Signed-off-by: Daniel Aleksandersen <[email protected]>
@da2x da2x requested a review from Kubuxu as a code owner January 28, 2019 07:19
@da2x
Copy link
Contributor Author

da2x commented Jan 28, 2019

I don’t beleive that the remaining failure is caused by the changes in this branch.

@magik6k magik6k requested a review from djdv January 28, 2019 17:02
Copy link
Contributor

@djdv djdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change line line 70 from
Please install it yourself by running:
to
To proceed, please make sure $GOPATH/bin is in your $PATH and install the tool yourself by running:
Or something similar.

@da2x
Copy link
Contributor Author

da2x commented Jan 28, 2019

To proceed, please make sure $GOPATH/bin is in your $PATH and install the tool yourself by running:

That test could be automated to say definitively whether $GOPATH/bin is in $PATH or not. However, I don’t intend to work on that now as part of this tiny pull request.

@djdv
Copy link
Contributor

djdv commented Jan 28, 2019

@da2x
Fair enough.
I figure it may be good to have a note now and automation later, but I'm not going to block on that.
I'll defer to @Stebalien on this.

Edit: I'll likely deal with that myself later in the new fuse implementation.

@Stebalien Stebalien merged commit 7ab32c3 into ipfs:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants