-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return a json object from config show #5345
Conversation
@diasdavid is this likely to break something? |
This doesn't change there CLI output, it just means that the server responds with a JSON output by default. fixes #5335 License: MIT Signed-off-by: Steven Allen <[email protected]>
So, this does cause a bit of an issue: Users using old clients against newer servers won't see nicely formatted json, they'll see dense json. However, I'm not too concerned about that. Clients with this patch applied still work correctly against older servers. |
This seems fine to me, but I would double check with the javascripters before merging. |
If the Content-Type header is now |
It is. These are the old headers:
These are the new headers:
Note that the |
Great @Stebalien ! 😄 |
We should test it out against js-ipfs-api to be 100% sure. We should probably also test out go-ipfs-api and java-ipfs-api. This is touchy change as it changes a default behaviour. |
@Kubuxu looks like this'll work just fine with js-ipfs-api as js-ipfs already behaves this way. |
I'll take the comments from @hacdias and @whyrusleeping as "two signoffs". |
This doesn't change there CLI output, it just means that the server responds with a JSON output by default.
Fixes #5335.