when running an external command, only construct a node if running in online mode #5194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
This breaks commands like `ipfs update` that expect IPFS to *not* be running. fixes #5191 License: MIT Signed-off-by: Steven Allen <[email protected]>
License: MIT Signed-off-by: Steven Allen <[email protected]>
Stebalien
changed the title
Stebalien
added
need/review
| if err == nil { | ||
| // Get the node iff already defined. | ||
| if req.InvocContext().Online { | ||
| nd, err := req.InvocContext().GetNode() |
There was a problem hiding this comment.
we can probably just skip this GetNode call entirely and just use the req.InvocContext().Online value directly below for setting the variable
There was a problem hiding this comment.
I wanted to ensure we actually created the node. Online means "node will be constructed in online mode" but I don't know if it actually constructs the node. Actually, I'm pretty sure it doesn't.
whyrusleeping
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks commands like
ipfs updatethat expect IPFS to not be running.fixes #5191