build: remove fuse platform constraints #5033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
djdv
force-pushed
the
fix/unsupported-build
branch
from
4d370af
to
d2b0367
Compare
djdv
changed the title
djdv
force-pushed
the
fix/unsupported-build
branch
2 times, most recently
from
b71bc10
to
68f976e
Compare
|
Also |
|
Can we get some people to confirm this works as intended? cc @daftaupe |
|
@whyrusleeping, @djdv's patch is building fine, at least on my DragonFlyBSD server :) |
|
cool, i guess let's merge this one then. @djdv mind rebasing? |
License: MIT Signed-off-by: Dominic Della Valle <[email protected]>
djdv
force-pushed
the
fix/unsupported-build
branch
from
68f976e
to
56eb2b0
Compare
|
@whyrusleeping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to: #5031
@daftaupe was expressing issues on IRC when trying to build
go-ipfson DragonflyBSD. After investigating, it seemed like the only problem was in the build constraints. I suggested adding dragonfly to the list of build targets. This worked fine but may be unnecessary (see: #5031 (comment))It may be best to just remove these constraints so people don't have to rediscovering this and make source modifications when using the
install_unsupportedmaketarget on platforms that are not explicitly defined by us.