Show diff in 'config profile' commands, add dry-run flag #4923
Conversation
License: MIT Signed-off-by: Jeromy <[email protected]>
License: MIT Signed-off-by: Preet <[email protected]>
|
I couldn't fetch the copy of jsondiff that you imported so I re-imported it (QmTGd4vj3ZjBj8zY7aBYpp7LN3L2DiXbhd8YRLYu9papZk) and pinned it. |
| strDiff := string(byteDiff[:]) | ||
|
|
||
| fmt.Println("Defference between current config and config that will be generated :\n ") | ||
| fmt.Println(strDiff) |
There was a problem hiding this comment.
We use a server-client model for our commands so, instead of printing here, we'll want to send the result back to the user (using res.SetOutput(diff)).
I'd send the output of jsondiff.Compare and then format it on the client in an Encoder/Marshaler.
We actually have two commands system. An old one (that we're slowly replacing) and a new one. Unfortunately, this command uses the old system. If you're up to it, I'd consider migrating it to the new system as that'll make this extension a bit easier.
If you do migrate it, you'll need to define an Encoder like we do in the patchAppendDataCmd command in core/commands/object/patch.go. If you don't want to deal with migrating it, you'll have to define a marshaler as is done in the version command in core/commands/version.go.
There was a problem hiding this comment.
One open question is: Should we always return the diff and make --dry-run just mean "don't apply the change"
I think that's what we'd want
magik6k
changed the title
|
Continued in #5455. |
Issue: #4914
package jsondiff has been added to gx and is used to show user the difference between the original config and config that will be generated when
config profile apply --dry-runis run