badger: Update to fix i386 windows build #4464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
whyrusleeping
approved these changes
Dec 7, 2017
|
@Stebalien the changes you made are failing the travis builds I think |
Stebalien
force-pushed
the
gx/update-badger
branch
2 times, most recently
from
cc66c86
to
074a3f6
Compare
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
closes #4438 License: MIT Signed-off-by: Steven Allen <[email protected]>
We were doing this as part of the `test` target but we don't run that on CI (or at least not on Travis). License: MIT Signed-off-by: Steven Allen <[email protected]>
1. We don't need it (technically). 2. TravisCI (well, Ubuntu Trusty) is using a 11 year old version of make without support for this feature. License: MIT Signed-off-by: Steven Allen <[email protected]>
Stebalien
force-pushed
the
gx/update-badger
branch
from
074a3f6
to
ddcf5ad
Compare
|
@whyrusleeping this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4438