add UUID to root context #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Brian Tiger Chow <[email protected]>
btc
changed the title
|
im so excited! started from the bottom now we're here |
| if i.req == nil { | ||
| return nil, errors.New("constructing node without a request") | ||
| } | ||
| func (i *cmdInvocation) nodeFunc(ctx context.Context) func() (*core.IpfsNode, error) { |
There was a problem hiding this comment.
nodeFunc reads more like a getter. maybe either
constructNodeFunc- make the function check
if i.node != nil {
return i.node, nil
}
|
RFM? |
|
@maybebtc thanks, yep! |
|
in action
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #435
We probably want to officially deprecate the command context and use the context.Context to shuttle the data (config path, etc.) across the boundary (main -> commands lib -> ipfs command). Yet another TODO.