gx: update ipldcbor #4067
Merged
gx: update ipldcbor #4067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but I would prefer for #4033 to be merged first, resolving merge conflict will be easier on this side. |
|
Sure. It doesn't look like IPFS is hitting this bug anyways. |
|
@Stebalien wanna rebase? |
Stebalien
force-pushed
the
gx/update-cbor
branch
4 times, most recently
from
3310967
to
1fb1bac
Compare
I previously optimized the IPLD cbor decoder to *not* encode and then re-decode objects when constructing them with `WrapObject`. Unfortunately, we rely on this to canonicalize the object before computing the tree/links. License: MIT Signed-off-by: Steven Allen <[email protected]>
Stebalien
force-pushed
the
gx/update-cbor
branch
from
1fb1bac
to
e8f6486
Compare
Kubuxu
approved these changes
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previously optimized the IPLD cbor decoder to not encode and then re-decode
objects when constructing them with
WrapObject. Unfortunately, we rely on thisto canonicalize the object before computing the tree/links.