remove all instances of Default(false)
#4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should wait until #3856 is merged as it can have conflicts with it. |
Boolean options always default to false. License: MIT Signed-off-by: Lorenzo Manacorda <[email protected]>
keks
force-pushed
the
fix/default-false
branch
from
a3ebfa2
to
57f544a
Compare
ghost
assigned 
Kubuxu
approved these changes
Nov 21, 2017
Merged
kevina
approved these changes
Nov 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boolean options always default to false.
As mentioned here.