Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corehttp: cleanup close handling #3585

Closed
wants to merge 1 commit into from
Closed

corehttp: cleanup close handling #3585

wants to merge 1 commit into from

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Jan 10, 2017

License: MIT
Signed-off-by: Jakub Sztandera [email protected]

@Kubuxu
corehttp: cleanup close handling
9eb44d1 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu Kubuxu added the status/in-progress In progress label Jan 10, 2017
@Kubuxu Kubuxu mentioned this pull request Jan 10, 2017
Closed
@Kubuxu Kubuxu added this to the ipfs 0.4.5 milestone Jan 10, 2017
@ghost
Copy link

ghost commented Jan 10, 2017

Yes this is better, LGTM 👍

@whyrusleeping
Copy link
Member

better, yet seems to break everything...

@Kubuxu
Copy link
Member Author

Kubuxu commented Jan 10, 2017 •
edited
Loading

Yup.
See: https://github.com/ipfs/go-ipfs/pull/3585/files#diff-19ceb36d78bde310c54cc44a95bec44cR166

In this case we shouldn't close.

@Kubuxu Kubuxu closed this Jan 10, 2017
@Kubuxu Kubuxu removed the status/in-progress In progress label Jan 10, 2017
@whyrusleeping whyrusleeping deleted the feat/corehttp/defer-close-move branch January 11, 2017 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ipfs 0.4.5
Development

Successfully merging this pull request may close these issues.
2 participants
@Kubuxu @whyrusleeping