Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update message.proto #3476

Merged
merged 1 commit into from
Dec 7, 2016
Merged

update message.proto #3476

merged 1 commit into from
Dec 7, 2016

Conversation

daviddias
Copy link
Member

Add some comments so that I don't forget about these

@daviddias daviddias added the status/in-progress In progress label Dec 7, 2016
@whyrusleeping
Copy link
Member

@diasdavid fix your commit msg pls

@daviddias daviddias force-pushed the docs/bitswap-proto branch 3 times, most recently from 17b732a to 97363bc Compare December 7, 2016 03:50
@daviddias
Copy link
Member Author

@whyrusleeping there:
image

@Kubuxu
Copy link
Member

Kubuxu commented Dec 7, 2016

gitcop doesn't like you as it wants email in triangular brackets.

Add some comments so that I don't forget about these

License: MIT
Signed-off-by: David Dias <[email protected]>
@daviddias
Copy link
Member Author

thank you @Kubuxu, I was missing that

Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks D#

@whyrusleeping whyrusleeping merged commit f43811a into master Dec 7, 2016
@whyrusleeping whyrusleeping deleted the docs/bitswap-proto branch December 7, 2016 18:38
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Dec 7, 2016
@ghost ghost mentioned this pull request Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants