Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require CI to pass for coverage #3474

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Dec 6, 2016

If travis fail (or is cancelled) or random build failure happens, or
js-ipfs-api test is down for a long time we still want the coverage.

WIP

License: MIT
Signed-off-by: Jakub Sztandera [email protected]

@Kubuxu Kubuxu added the status/in-progress In progress label Dec 6, 2016
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kubuxu
Copy link
Member Author

Kubuxu commented Dec 6, 2016

I want to check if it works, if not I have other idea still.

If travis fail (or is cancelled) or random build failure happens, or
js-ipfs-api test is down for a long time we still want the coverage.

License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Copy link
Member Author

Kubuxu commented Dec 7, 2016

@whyrusleeping it is done.

@Kubuxu Kubuxu added the need/review Needs a review label Dec 7, 2016
@whyrusleeping whyrusleeping merged commit 24d35f3 into master Dec 7, 2016
@whyrusleeping whyrusleeping deleted the feat/codecov/skip-ci branch December 7, 2016 01:11
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Dec 7, 2016
@ghost ghost mentioned this pull request Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/review Needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants