Issue #3419: Do not recursively resolve DAG just to obtain a CID #3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Hector Sanjuan <[email protected]>
ghost
approved these changes
Nov 24, 2016
| @@ -269,6 +269,11 @@ type RefKeyList struct { | |||
|
|
|||
| func pinLsKeys(args []string, typeStr string, ctx context.Context, n *core.IpfsNode) (map[string]RefKeyObject, error) { | |||
|
|
|||
| mode, ok := pin.StringToPinMode(typeStr) | |||
| if !ok { | |||
| return nil, fmt.Errorf("Invalid pin mode '%s'", typeStr) | |||
There was a problem hiding this comment.
Thanks for pointing out. Fixed
Kubuxu
approved these changes
Nov 24, 2016
License: MIT Signed-off-by: Hector Sanjuan <[email protected]>
|
LGTM Note this will still hit the network for paths which aren't just plain /ipfs/hash (e.g. /ipns/hash or /ipfs/hash/foo) -- but that's fine and I feel like it's expected. |
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| mode, ok := pin.StringToPinMode(typeStr) |
There was a problem hiding this comment.
Oh, wait, i see. you just moved this code.
There was a problem hiding this comment.
This was moved to the beginning of the function, line 272
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve() tries to fetch the object to check if it has to recursively do something with children (I think). It's overkill here (I think). See #3419