Revert "http api: makes sure header is sent even when r is not ready … #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keks
force-pushed
the
fix/fix-adding
branch
2 times, most recently
from
95d03ce
to
f25763b
Compare
Revert "http api: makes sure header is sent even when r is not ready yet. fixes ipfs#3304 (ipfs#3305)" This reverts commit 68d8a29. License: MIT Signed-off-by: Jan Winkelmann <[email protected]>
|
thanks @keks. That was a really great bit of deep diving research, we're definitely going to have to find a better way forward for the api |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…yet. fixes #3304 (#3305)"
This reverts commit 68d8a29.
This broke ipfs add from js-ipfs-api. Related discussion on the commit page and at #3336.