Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "http api: makes sure header is sent even when r is not ready … #3366

Merged
merged 1 commit into from
Nov 9, 2016

Conversation

keks
Copy link
Contributor

@keks keks commented Nov 7, 2016

…yet. fixes #3304 (#3305)"

This reverts commit 68d8a29.

This broke ipfs add from js-ipfs-api. Related discussion on the commit page and at #3336.

@keks keks force-pushed the fix/fix-adding branch 2 times, most recently from 95d03ce to f25763b Compare November 7, 2016 22:23
Revert "http api: makes sure header is sent even when r is not ready yet. fixes ipfs#3304 (ipfs#3305)"
This reverts commit 68d8a29.

License: MIT
Signed-off-by: Jan Winkelmann <[email protected]>
@whyrusleeping
Copy link
Member

thanks @keks. That was a really great bit of deep diving research, we're definitely going to have to find a better way forward for the api

@whyrusleeping whyrusleeping merged commit 8d6ac7a into ipfs:master Nov 9, 2016
@ghost ghost mentioned this pull request Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API call to pubsub/sub does not return HTTP header until first message arrives
2 participants