bitswap: protocol extension to handle cids #3297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
feat/bitswap-cid
branch
from
7a65328
to
0332349
Compare
Kubuxu
reviewed
Oct 10, 2016
| for _, d := range pbm.GetBlocks() { | ||
| fmt.Println("got old style block") |
There was a problem hiding this comment.
oh right, those debug logs...
| // | ||
|
|
||
| for _, b := range pbm.GetPayload() { | ||
| fmt.Println("got new style block") |
There was a problem hiding this comment.
This is also leftover debug logging.
| b := blocks.NewBlock(d) | ||
| m.AddBlock(b) | ||
| } | ||
| // |
| for _, d := range pbm.GetBlocks() { | ||
| fmt.Println("got old style block") | ||
| // CIDv0, sha256, protobuf only | ||
| b := blocks.NewBlock(d) | ||
| m.AddBlock(b) |
There was a problem hiding this comment.
What in the case that both v0 and v1 fields are used? Just allow it? Log it?
There was a problem hiding this comment.
I'm fine just allowing it for now.
| } | ||
|
|
||
| func (m *impl) ToNetV0(w io.Writer) error { | ||
| fmt.Println("V0") |
whyrusleeping
force-pushed
the
feat/bitswap-cid
branch
from
0332349
to
224c6a1
Compare
|
I have two more PR's ready to go (already written) once this one is in. So lets get review on this ASAP |
whyrusleeping
force-pushed
the
feat/bitswap-cid
branch
2 times, most recently
from
8531ed0
to
f4d7369
Compare
This change adds the /ipfs/bitswap/1.1.0 protocol. The new protocol adds a 'payload' field to the protobuf message and deprecates the existing 'blocks' field. The 'payload' field is an array of pairs of cid prefixes and block data. The cid prefixes are used to ensure the correct codecs and hash functions are used to handle the block on the receiving end. License: MIT Signed-off-by: Jeromy <[email protected]>
|
LGTM |
ghost
mentioned this pull request
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Apr 7, 2022
bitswap: protocol extension to handle cids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the /ipfs/bitswap/1.1.0 protocol. The new protocol
adds a 'payload' field to the protobuf message and deprecates the
existing 'blocks' field. The 'payload' field is an array of pairs of cid
prefixes and block data. The cid prefixes are used to ensure the correct
codecs and hash functions are used to handle the block on the receiving
end.
cc @diasdavid @Kubuxu
License: MIT
Signed-off-by: Jeromy [email protected]