Doc/cmds/log notice unused #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because go-log does not support that level, although the underlying library, go-logging, does. License: MIT Signed-off-by: Jesse Weinstein <[email protected]>
License: MIT Signed-off-by: Jesse Weinstein <[email protected]>
|
This LGTM, @Kubuxu @RichardLitt ? |
|
LGTM |
| @@ -35,8 +35,7 @@ var logLevelCmd = &cmds.Command{ | |||
| Helptext: cmds.HelpText{ | |||
| Tagline: "Change the logging level.", | |||
| ShortDescription: ` | |||
| 'ipfs log level' is a utility command used to change the logging | |||
| output of a running daemon. | |||
| Change the verbosity of one or all subsystems log output. Does NOT affect the event log. | |||
There was a problem hiding this comment.
I would change NOT to not. It says it without needing to draw attention to it. Also, This does not... is better, I think.
License: MIT Signed-off-by: Jesse Weinstein <[email protected]>
|
Suggested changes applied. |
|
LGTM. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the unused
noticelevel from the help text, and also clarifies the distinction between the event log output and the other log output (at least, as best as I currently understand the distinction).