-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump go requirement to 1.7 #3111
Conversation
License: MIT Signed-off-by: Jeromy <[email protected]>
License: MIT Signed-off-by: Jeromy <[email protected]>
@diasdavid the js-ipfs-api test failures look like an issue on your end. Could you confirm and let me know when there is a fix? |
the docker thing needs fixing too, fun. |
@whyrusleeping the error is:
Because the key we selected to
I can update the tests to use some other key, is this decision final with regards to not being able to access Identity from the API? How does the go CLI do it then? Some special whitelisting for go-ipfs cli? |
@diasdavid yeah, you can't access anything containing the private key via the api in any way (including the CLI). You could use identity.peerID if you wanted |
Go 1.7 funnily demands gcc for installing gx. License: MIT Signed-off-by: Lars Gierth <[email protected]>
CI is gonna be fun with this one...
License: MIT
Signed-off-by: Jeromy [email protected]