Improve ping API a bit by returning failure in case of only failure #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ctx, cancel := context.WithTimeout(ctx, kPingTimeout*time.Duration(numPings)) | ||
| defer cancel() | ||
| pings, err := n.Ping.Ping(ctx, pid) | ||
| if err != nil { | ||
| log.Debugf("Ping error: %s", err) | ||
| outChan <- &PingResult{Text: fmt.Sprintf("Ping error: %s", err)} | ||
| outChan <- &PingResult{ | ||
| Text: fmt.Sprintf("Ping error: %s", err)} |
There was a problem hiding this comment.
lets explicitly set Success false here (for clarity to the reader), and then put the closing bracket on its own line.
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
|
Updated. |
|
Not quite sure what this does-- the PR title doesn't tell me, and the code is not clear why-- maybe add some comments why some return success and one fail? |
|
We have boolean filed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2803
License: MIT
Signed-off-by: Jakub Sztandera [email protected]