Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/buffer err chan #2788

Merged
merged 2 commits into from
Jun 1, 2016
Merged

Fix/buffer err chan #2788

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4f2d1d
buffer error chan to prevent dead goro buildup
whyrusleeping Jun 1, 2016
82a2218
localize context cancellation in PutRecordToRouting
whyrusleeping Jun 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion namesys/publisher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ func checkCtxTTL(ctx context.Context) (time.Duration, bool) {
}

func PutRecordToRouting(ctx context.Context, k ci.PrivKey, value path.Path, seqnum uint64, eol time.Time, r routing.IpfsRouting, id peer.ID) error {
ctx, cancel := context.WithCancel(ctx)
defer cancel()

namekey, ipnskey := IpnsKeysForID(id)
entry, err := CreateRoutingEntryData(k, value, seqnum, eol)
if err != nil {
Expand All @@ -146,7 +149,7 @@ func PutRecordToRouting(ctx context.Context, k ci.PrivKey, value path.Path, seqn
entry.Ttl = proto.Uint64(uint64(ttl.Nanoseconds()))
}

errs := make(chan error)
errs := make(chan error, 2)

go func() {
errs <- PublishEntry(ctx, r, ipnskey, entry)
Expand Down