Moved Tests up in Contribute.md #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be more prominent. We also need a much better description of how to run tests - rigt now, we are dependant on Travis for the majority of testing, I believe. If there was a clear guide here on how to run the appropriate tests for each kind of PR, that would be fantastic. We also really ought to have a section asking people to add all of the tests that they can think of. License: MIT Signed-off-by: Richard Littauer <[email protected]>
License: MIT Signed-off-by: Richard Littauer <[email protected]>
RichardLitt
force-pushed
the
feature/contribute-tests-section
branch
from
14e9326
to
b620817
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be more prominent. We also need a much better description of how to run tests - rigt now, we are dependant on Travis for the majority of testing, I believe. If there was a clear guide here on how to run the appropriate tests for each kind of PR, that would be fantastic.
We also really ought to have a section asking people to add all of the tests that they can think of.
License: MIT
Signed-off-by: Richard Littauer [email protected]