Support for listing only cached links in refs command #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cmds.BoolOption("edges", "e", "Emit edge format: `<from> -> <to>`."), | ||
| cmds.BoolOption("unique", "u", "Omit duplicate refs from output."), | ||
| cmds.BoolOption("recursive", "r", "Recursively list links of child nodes."), | ||
| cmds.BoolOption("cached", "List only links of child nodes cached locally"), |
sivachandran
force-pushed
the
cached_refs_v4
branch
from
1c957a8
to
bba2f62
Compare
|
@sivachandran I finally got #2257 merged. If you want to continue on here, let me know. |
Added "--cached" option to "refs" command that lists only cached links. Also added "linksize" token in format to print the size of the link. By listing only cached refs and their sizes we can easily find the cache/download progress of an object. License: MIT Signed-off-by: Sivachandran <[email protected]>
License: MIT Signed-off-by: Sivachandran <[email protected]>
License: MIT Signed-off-by: Sivachandran <[email protected]>
Link cached status was determined by checking the presence of link hash in blockstore. Now link cached status is determined by successfully getting node from DAG. License: MIT Signed-off-by: Sivachandran <[email protected]>
sivachandran
force-pushed
the
cached_refs_v4
branch
from
cdfff80
to
60bc015
Compare
|
@whyrusleeping Updated the changes based on PR #2257. But NodeGetter is not returning ErrNotFound when the node is not found, rather it returns "failed to fetch all nodes" error. |
|
@sivachandran pr #2257 has been merged, if you'd like to continue this PR that would be good. We'd love to have a generalized way to listed the subset of refs under a given hash that are cached locally for a 'best effort' pin mechanism for mfs. this is very relevant to that effort |
|
Has been idle for about a year. Closing for now. Please do feel free to reopen this as necessary. Closing old PRs just helps us more easily see what needs immediate attention |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "--cached" option to "refs" command that lists only cached links. Also added "linksize" token in format to print the size of the link. By listing only cached refs and their sizes we can easily find the cache/download progress of an object.
License: MIT
Signed-off-by: Sivachandran [email protected]