-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevents 'ipfs name publish' when /ipns is mounted. #2323
Prevents 'ipfs name publish' when /ipns is mounted. #2323
Conversation
test_launch_ipfs_daemon | ||
|
||
# wait for peer bootstrapping | ||
# TODO(noffle): this is very fragile -- how can we wait for this to happen for sure? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check the other iptb tests to see how i wait for bootstrapping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly, the functions in test/sharness/lib/iptb-lib.sh
1a24479
to
76add1f
Compare
Nice! |
|
||
# start iptb + wait for peering | ||
NUM_NODES=3 | ||
iptb init -n $NUM_NODES -f --bootstrap=none --port=0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw this in a test_expect_success
one small comment and LGTM |
Looks like CI likes me. Ready for merge? |
LGTM, wanna rebase and i'll merge? |
Done. |
abf5478
to
f4367f6
Compare
License: MIT Signed-off-by: Stephen Whitmore <[email protected]>
License: MIT Signed-off-by: Stephen Whitmore <[email protected]>
License: MIT Signed-off-by: Stephen Whitmore <[email protected]>
License: MIT Signed-off-by: Stephen Whitmore <[email protected]>
Prevents 'ipfs name publish' when /ipns is mounted.
Thanks! |
Addresses #1186.