Base of IPNS #19
Base of IPNS #19
Conversation
| b58Exp := "^[123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz]*$" | ||
| pqExp := "^([abdfghijklmnoprstuvz]{5}-)*[abdfghijklmnoprstuvz]{5}$" | ||
|
|
||
| isB58, err := regexp.MatchString(b58Exp, name) |
There was a problem hiding this comment.
youre losing this error here, you should probably check it before calling match string a second time.
There was a problem hiding this comment.
Thank you! Should be better now.
|
Cool stuff! Glad to get started on this part. One problem: name resolution ( Beyond this fundamental difference, there are other strong reasons to keep mutable and immutable paths completely separate. Certain applications may opt to operate entirely on immutable objects, and we can optionally upgrade the naming system without altering the immutable objects at all. The importance of making mutable and immutable data clearly distinct -- and the importance of separating the subsystems -- became clear when studying the designs of systems like git ( So yeah, let's revert back to having path resolution as just immutable data, and doing name solution on top (names resolve to the top level object, and pass along resolution to |
|
The latest commit will require resetting your .go-ipfs folder for IPFS to work, because there was a commit change. |
|
Cool! Let's rebase this branch on top of new master -- rather than merging master in. Are you comfortable with rebases? Took me a while, so happy to walk you through it on IRC. |
- Delete name.go - Update path.go - Update namesys.go
|
For future ref, these were rebased from: 794dc10...48665af |
| @@ -7,7 +7,7 @@ import ( | |||
|
|
|||
| // Identity tracks the configuration of the local node's identity. | |||
| type Identity struct { | |||
| PeerID string | |||
| Curve uint16 | |||
There was a problem hiding this comment.
Hey, why is the PeerID removed here? PeerIDs will survive beyond each launch (we don't generate them every time). Identities matter in BitSwap.
Gateway.NoFetch
Gateway.NoFetch
Gateway.NoFetch
Gateway.NoFetch
Wait for all go routines to finish before function returns
fixes #19 This commit was moved from ipfs/go-ipfs-http-client@8e3552a
Adds the ability to express paths as either a base58 hash, a proquint id, or as a domain name (through a DNS TXT record).