Gateway composite file add

[rht]

• Depends on Move parts of ipfs add into core/coreunix #1778 to be merged
• tests (curl can only upload multiple files with PUT, but not structured files with dir)
• pin parameter
• obsoletes core/corehttp: add support for posting directories to gateway #1543
• fixes gateway: file upload functionality? #1819

[whyrusleeping]

hmm... two panics in the failed test, neither appear to be related to this PR. but the second one seems like an actual problem.

[rht]

@cryptix this should have been in putHandler?

[rht]

@whyrusleeping panic test (the stalled build one) once again.

[cryptix]

The original put handler took json similar too "ipfs object put"

[prusnak]

What is the state of this?

[rht]

this needs test

[prusnak]

What do you mean by test? Should I grab your branch and test if it works? Or should we rebase on top of ipfs:dev0.4.0 and test this?

[rht]

Test as in sharness test to make sure the POST multipart work. Currently making it.

The current master is already 0.4.0.

[prusnak]

Cool! Let me know if I can help somehow. Would love to see this feature
merged in soon.

Best Regards / S pozdravom,

Pavol Rusnak [email protected]

On Fri, Jan 15, 2016, at 03:17 PM, rht wrote:

Test as in sharness test to make sure the POST multipart work. Currently making it.

The current master is already 0.4.0.

—
Reply to this email directly or view it on GitHub[1].

Links:

1. Gateway composite file add #1845 (comment)

[GitCop]

There were the following issues with your Pull Request

• Commit: c242660
  • Invalid signoff. Commit message must end with
    License: MIT
    Signed-off-by: .* <.*>
• Commit: 38a600b
  • Invalid signoff. Commit message must end with
    License: MIT
    Signed-off-by: .* <.*>

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
git commit --amend can often help you quickly improve the commit message.
Guidelines and a script are available to help in the long run.
Your feedback on GitCop is welcome on this issue.

---

This message was auto-generated by https://gitcop.com

[rht]

@prusnak figuring out how to use curl POST that is also specified in rfc1867 and updating the api documentation in https://github.com/ipfs/js-ipfs-api/blob/master/README.md (this has the multipart/form-data example, but only for a single file).

I have fixed the merge conflicts in #2205.

[rht]

I'm using this for multiple files POST: https://github.com/ipfs/go-ipfs/pull/2205/files#diff-cbe32203deec9b995950e3110e5db668R69. But there should be a tool that auto-convert file arguments / directory into a multipart form for curl?

[prusnak]

Does master already support single file upload using curl -X POST --data-binary @infile "$URL"?

[rht]

Yes it does, it is used in one of the test https://github.com/ipfs/go-ipfs/blob/c1847e9f693e716a54e0223e44729c76ef64308b/test/sharness/t0111-gateway-writeable.sh#L30

[prusnak]

Great, I just tested it at it works. Wohooo!