-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gateway: embed directory-listing styles #1615
Conversation
License: MIT Signed-off-by: Lars Gierth <[email protected]>
May want to work on https://github.com/ipfs/dir-index-html |
#1487 now works. Forgot to trim the trailing newline: https://github.com/ipfs/go-ipfs/pull/1487/files#diff-d68d022661f02d0093d7693d0a76b010R32 |
@rht let's rebase + land that PR. then we can make @lgierth's changes on top. we should also fix some of the stuff here: https://github.com/ipfs/dir-index-html/issues |
@lgierth how to generate the 'minified' index page here? |
gulp-inject / gulp-usemin / gulp-useref? However can't vendor npm packages in dir-index-html repo because package.json is used for gx. |
@lgierth if you can concat the css and html file in dir-index-html (optionally vendor the concat build script later), I will then update the gx package here in go-ipfs. |
AFAIK, gx and npm can be used in same package/repo. they shouldn't conflict? if they do, we should change that. other PMs make a point not to conflict because invariably people end up having to use multiple systems. cc @whyrusleeping |
@rht it's from here https://gateway.ipfs.io/ipfs/QmWxrgcm6nTNbRB7S2ugq7Wfw3pD1FVBTN6WMtkHiD396u/bundle.css (courtesy of @krl) |
@whyrusleeping https://github.com/whyrusleeping/gx/blob/master/gxutil/pkgfile.go#L11 if this is |
What about collision with godep in go 1.5? |
@rht which collision? i'm going to move from putting packages in |
Based on ipfs#1615 License: MIT Signed-off-by: rht <[email protected]>
Based on ipfs#1615 License: MIT Signed-off-by: rht <[email protected]>
Based on ipfs#1615 License: MIT Signed-off-by: rht <[email protected]>
Based on ipfs#1615 License: MIT Signed-off-by: rht <[email protected]>
Based on ipfs#1615 License: MIT Signed-off-by: rht <[email protected]>
Since gx now is compatible with go1.5 vendor/, the question has been obsolete. This PR can be closed, 8ec1212 |
(here goes) |
cool 🍰 |
Based on ipfs/kubo#1615 License: MIT Signed-off-by: rht <[email protected]> This commit was moved from ipfs/kubo@8ec1212
This embeds bootstrap.css and icons.css into the index page, so that the styles are always available, even when we're on a static page hosted off IPFS, where
/ipfs
and/ipns
aren't exposed.Travis failure is from mock_notif_test.