Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: embed directory-listing styles #1615

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Aug 28, 2015

This embeds bootstrap.css and icons.css into the index page, so that the styles are always available, even when we're on a static page hosted off IPFS, where /ipfs and /ipns aren't exposed.

Travis failure is from mock_notif_test.

License: MIT
Signed-off-by: Lars Gierth <[email protected]>
@ghost ghost added the topic/gateway Topic gateway label Aug 28, 2015
@jbenet jbenet added the status/in-progress In progress label Aug 28, 2015
@ghost ghost mentioned this pull request Aug 28, 2015
56 tasks
@jbenet
Copy link
Member

jbenet commented Aug 28, 2015

@rht
Copy link
Contributor

rht commented Aug 28, 2015

@jbenet
Copy link
Member

jbenet commented Aug 28, 2015

@rht let's rebase + land that PR. then we can make @lgierth's changes on top. we should also fix some of the stuff here: https://github.com/ipfs/dir-index-html/issues

@ghost ghost mentioned this pull request Aug 30, 2015
3 tasks
@daviddias daviddias mentioned this pull request Sep 2, 2015
42 tasks
@rht
Copy link
Contributor

rht commented Sep 3, 2015

@lgierth how to generate the 'minified' index page here?

@rht
Copy link
Contributor

rht commented Sep 3, 2015

gulp-inject / gulp-usemin / gulp-useref? However can't vendor npm packages in dir-index-html repo because package.json is used for gx.

@rht
Copy link
Contributor

rht commented Sep 3, 2015

@lgierth if you can concat the css and html file in dir-index-html (optionally vendor the concat build script later), I will then update the gx package here in go-ipfs.

@jbenet
Copy link
Member

jbenet commented Sep 3, 2015

can't vendor npm packages in dir-index-html repo because package.json is used for gx.

AFAIK, gx and npm can be used in same package/repo. they shouldn't conflict? if they do, we should change that. other PMs make a point not to conflict because invariably people end up having to use multiple systems. cc @whyrusleeping

@ghost
Copy link
Author

ghost commented Sep 3, 2015

@whyrusleeping
Copy link
Member

@rht @jbenet yeah, i would hope npm and gx can coexist, any issues between the two should be reported (granted, i havent tried that yet)

@rht
Copy link
Contributor

rht commented Sep 3, 2015

@rht
Copy link
Contributor

rht commented Sep 3, 2015

What about collision with godep in go 1.5?

@whyrusleeping
Copy link
Member

@rht which collision? i'm going to move from putting packages in vendor/src to just putting them in vendor to comply with the go1.5 vendoring spec.

rht added a commit to rht/go-ipfs that referenced this pull request Sep 4, 2015
Based on ipfs#1615

License: MIT
Signed-off-by: rht <[email protected]>
rht added a commit to rht/go-ipfs that referenced this pull request Sep 4, 2015
Based on ipfs#1615

License: MIT
Signed-off-by: rht <[email protected]>
rht added a commit to rht/go-ipfs that referenced this pull request Sep 4, 2015
Based on ipfs#1615

License: MIT
Signed-off-by: rht <[email protected]>
rht added a commit to rht/go-ipfs that referenced this pull request Sep 4, 2015
Based on ipfs#1615

License: MIT
Signed-off-by: rht <[email protected]>
rht added a commit to rht/go-ipfs that referenced this pull request Sep 4, 2015
Based on ipfs#1615

License: MIT
Signed-off-by: rht <[email protected]>
@rht
Copy link
Contributor

rht commented Oct 3, 2015

Since gx now is compatible with go1.5 vendor/, the question has been obsolete.

This PR can be closed, 8ec1212

@rht
Copy link
Contributor

rht commented Oct 3, 2015

(here goes)

@rht rht closed this Oct 3, 2015
@jbenet jbenet removed the status/in-progress In progress label Oct 3, 2015
@ghost
Copy link
Author

ghost commented Oct 3, 2015

cool 🍰

@ghost ghost deleted the directory-listing-css branch July 9, 2016 23:31
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
Based on ipfs/kubo#1615

License: MIT
Signed-off-by: rht <[email protected]>


This commit was moved from ipfs/kubo@8ec1212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/gateway Topic gateway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants