net/p2p + secio: parallelize crypto handshake #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a very nasty problem: handshakes were serial so incoming dials would wait for each other to finish handshaking. this was particularly problematic when handshakes hung-- nodes would not recover quickly. This led to gateways not bootstrapping peers fast enough. The approach taken here is to do what crypto/tls does: defer the handshake until Read/Write[1]. There are a number of reasons why this is _the right thing to do_: - it delays handshaking until it is known to be necessary (doing io) - it "accepts" before the handshake, getting the handshake out of the critical path entirely. - it defers to the user's parallelization of conn handling. users must implement this in some way already so use that, instead of picking constants surely to be wrong (how many handshakes to run in parallel?) [0] http://golang.org/src/crypto/tls/conn.go#L886
|
This seems to pass. it's a very time sensitive push, so i'm going to merge it. Would appreciate CR anyway though cc @whyrusleeping @cryptix (oh and the code in there is icky. one day we'll switch to a simple AEAD primitive agl gives us or something). |
jbenet
added a commit
that referenced
this pull request
May 12, 2015
net/p2p + secio: parallelize crypto handshake
This was referenced May 12, 2015
Closed
| @@ -79,15 +67,60 @@ func (s *secureSession) LocalPrivateKey() ci.PrivKey { | |||
|
|
|||
| // RemotePeer retrieves the remote peer. | |||
| func (s *secureSession) RemotePeer() peer.ID { | |||
| if err := s.Handshake(); err != nil { | |||
| return "" | |||
There was a problem hiding this comment.
i'd at least log.Warning these errors.
There was a problem hiding this comment.
yeah, something something throwing away errors is the worst thing in the world
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a very nasty problem: handshakes were serial so incoming
dials would wait for each other to finish handshaking. this was
particularly problematic when handshakes hung-- nodes would not
recover quickly. This led to gateways not bootstrapping peers
fast enough.
The approach taken here is to do what crypto/tls does:
defer the handshake until Read/Write[0]. There are a number of
reasons why this is the right thing to do:
critical path entirely.
must implement this in some way already so use that, instead of
picking constants surely to be wrong (how many handshakes to run
in parallel?)
[0] http://golang.org/src/crypto/tls/conn.go#L886