config: rename addresses #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WARNING: change breaks old configs. @whyrusleeping @perfmode This commit changes the way addresses are stored in config files. It lumps Identity.Address and RPCAddress into Addresses. This commit also fixes several golint issues.
Closed
|
LGTM |
|
Merging. -- watch out folks, will break your configs. (perhaps overkill but...) i wrote a script to help your migrations: https://gist.github.com/jbenet/0ae83df1a0d4e5d8d37b -- maybe in the future it should be automatic. |
gammazero
added a commit
that referenced
this pull request
May 4, 2021
Needed to fix sharness tests due to this change: https://github.com/ipfs/go-ipfs-config/pull/121/files
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
remove duplicate entries in defaultServerFilters
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
remove duplicate entries in defaultServerFilters
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
remove duplicate entries in defaultServerFilters
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
remove duplicate entries in defaultServerFilters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: change breaks old configs.
@whyrusleeping @perfmode
This commit changes the way addresses are stored in config files. It lumps
Identity.Address and RPCAddress into Addresses. This commit also fixes several
golint issues.