Conversation
updates to use CheckIfPinnedWithType method from ipfs/boxo#1035, enabling efficient pin name retrieval for 'ipfs pin ls <cid> --names' - uses new CheckIfPinnedWithType from boxo for type-specific pin checks - pin names are now returned when listing specific CIDs with --names flag
lidel
changed the title
ipfs pin ls <cid> --names
This was referenced Sep 18, 2025
Closed
tests cover: - pin ls with specific CIDs returning names - pin ls without CID listing all pins with names - pin ls with --type and --names combinations - JSON output with and without names - pin update preserving names - error cases (invalid CID, unpinned CID)
covers fix for ipfs pin ls --names with specific CIDs and RPC pin name leak fix
passes the Name field from PinAddSettings to the API request adds test to verify pin names work via RPC
3 tasks
…062dad3e resolved conflicts in go.mod files to preserve the specific boxo version from the feature branch while accepting other updates from master
- test special characters, unicode, long names - test concurrent operations - test persistence across daemon restarts - test garbage collection preservation - fix indirect pin test logic
lidel
force-pushed
the
feat/pin-names-with-boxo
branch
from
99610ae to
b207869
Compare
- add nil check for n.Pinning with early fail-fast validation - use pin.StringToMode() for consistent type validation - add edge case tests for invalid types and unpinned CIDs
Member
Author
|
All green, included boxo@main with ipfs/boxo#1039, merging to unblock ipfs/js-kubo-rpc-client#343 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to use
CheckIfPinnedWithTypemethod from ipfs/boxo#1035, enabling efficient pin name retrieval for specific CID(s) viaipfs pin ls <cid> --names(rather having to list all and then filtering in post)TODO
ipfs pin ls <cid> --namesCheckIfPinnedWithTypefor efficient checks with names boxo#1035