rpc: retreive pin names when Detailed option provided#10966
Merged
gammazero merged 2 commits intoipfs:masterfrom Sep 12, 2025
Merged
rpc: retreive pin names when Detailed option provided#10966gammazero merged 2 commits intoipfs:masterfrom
gammazero merged 2 commits intoipfs:masterfrom
Conversation
Retaining the object during the loop will make fields such as `Name` stick between iterations. This patch decodes into a new struct each iteration, assuring we don't retain values from other pins.
hsanjuan
approved these changes
Sep 9, 2025
Contributor
hsanjuan
left a comment
There was a problem hiding this comment.
I'm unfamiliar with client, but in principle this seems ok. Maybe the others can point out any non-obvious ramifications.
gammazero
approved these changes
Sep 9, 2025
3 tasks
This was referenced Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #10965
Namedon't stick.trueorfalse, as configurable viacoreoptions.Pin.Ls.Detailed()This seems to match the documentation:
This should be a small bugfix, but if anyone thinks it belongs in the changelog, let me know and either I can add it or someone else can just push it themselves.