fix(config): wire up Provider.Enabled flag#10804
Merged
Conversation
Adds missing config option described in #10803
removing experiment, replaced with Provider.Enabled
lidel
force-pushed
the
feat/provider-toggle
branch
from
2029418 to
f28bc86
Compare
updated and added tests for manually triggering provide and reprovide and making them respect global configuration flag to avoid inconsistent behaviors
lidel
changed the title
Provider.Enable flagProvider.Enabled flag
lidel
changed the title
Provider.Enabled flagProvider.Enabled flag
guillaumemichel
approved these changes
May 14, 2025
Contributor
guillaumemichel
left a comment
guillaumemichel
left a comment
There was a problem hiding this comment.
Just wondering whether we actually want Reprovide.Interval=0 to disable the provide system altogether? (see comments)
- simplified default for both - 16 is safer for non-accelerated DHT client - acceletated DHT performs better without limit anyway - updated docs
Member
Author
|
Confirmed this PR (mainly, ability to disable provider queue) restores goroutine/memory utilization that is on par or better than v0.34.1 (internal notes from our staging env). Merging – will include this in 0.35.0-rc2. |
lidel
added a commit
that referenced
this pull request
May 15, 2025
* fix(config): explicit Provider.Enabled flag Adds missing config option described in #10803 * refactor: remove Experimental.StrategicProviding removing experiment, replaced with Provider.Enabled * test(cli): routing [re]provide updated and added tests for manually triggering provide and reprovide and making them respect global configuration flag to avoid inconsistent behaviors * docs: improve DelegatedRouters * refactor: default DefaultProviderWorkerCount=16 - simplified default for both - 16 is safer for non-accelerated DHT client - acceletated DHT performs better without limit anyway - updated docs (cherry picked from commit 2ab3f58)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kubo 0.35.0-rc1 had issues on Staging environment due too OOMs (internal notes).
@guillaumemichel and @gammazero suggested that the problem is related to provides, which should be disabled on that box. This PR aims to implement ability to fully disable provides (and reprovides) as noted in #10803 and unblock Kubo 0.35 (#10760)
TODO
Provider.Enabledis a global flag for disabling both Provider and Reprovider systems (announcing new/old CIDs to amino DHT).Experimental.StrategicProviding. Superseded byProvider.Enabled,Reprovider.IntervalandReprovider.Strategy.Provider.WorkerCountwhen no Accelerated DHT clientrouting [re]providecommands, ensure global flags are respectedProvider.WorkerCount