datastore: metrics datastore configuration optional and off by default#10788
Merged
datastore: metrics datastore configuration optional and off by default#10788
Conversation
lidel
requested changes
Apr 27, 2025
Member
lidel
left a comment
lidel
left a comment
There was a problem hiding this comment.
thank you @gammazero, i think this makes sense, but we should document which metrics are impacted – see asks inline
gammazero
force-pushed
the
init-no-measure-ds
branch
from
fc44f11 to
8f23b6f
Compare
When ipfs is initialized, the datastore metrics wrapper is not configured by default as it previously was. To enable datastore metrics during initialization, specifying the appropriate `--profile` option. To enable datastore metrics tracking wrapper, initialize with datastore profile name + "-measure" suffix. For example: ``` ipfs init --profile flatfs-measure ``` Closes #10767
gammazero
force-pushed
the
init-no-measure-ds
branch
from
d4850a6 to
0fb5cbf
Compare
lidel
approved these changes
Apr 30, 2025
Member
lidel
left a comment
lidel
left a comment
There was a problem hiding this comment.
lgtm, pushed changelog/docs cosmetics, if CI is green ok to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ipfs is initialized, the datastore metrics wrapper is not configured by default as it previously was. To enable datastore metrics during initialization, specifying the appropriate
--profileoption.To enable datastore metrics tracking wrapper, initialize with datastore profile name + "-measure" suffix. For example:
Closes #10767