chore: Basic UnixFS sanity checks

[PsychoPunkSage]

Changes:

• Basic Sanity checks for UnixFS nodes. <Raw data and dag-pb>
• Added no-validate flag to cmd.options

Closes #10331

[lidel]

triage note:

• thank you, this is useful, but needs regression test
• @PsychoPunkSage mind adding a test that confirms error occurs when someone tries to copy dag-cbor to MFS? (e.g. empty dag-cbor: bafyreigbtj4x7ip5legnfznufuopl4sg4knzc2cof6duas4b3q2fy6swua)

[gammazero]

See suggested changes and get CI passing first.

[PsychoPunkSage]

Hi @lidel I wrote a test and it is failing ig... currently solving it... Can give some suggestions which might help me

=== RUN   TestFilesCp_DagCborNodeFails
    /home/psychopunk_sage/dev/OpenSource/kubo/core/commands/file_test.go:55: expected error but got nil
--- FAIL: TestFilesCp_DagCborNodeFails (0.01s)
FAIL
FAIL    github.com/ipfs/kubo/core/commands      0.051s

@gammazero Made required changes....

[gammazero]

The test is failing because the type assertion for dag.RawNode succeeds, here.

To test your code, the test needs to create something that is not a dag.RawNode and is also not a dag.ProtoNode or is a dag.ProtoNode that fails when calling FSNodeFromBytes on node.(*dag.ProtoNode).Data()

[PsychoPunkSage]

Hi @gammazero
Thank you for help....

The Test is passing
Output

=== RUN   TestFilesCp_DagCborNodeFails
--- PASS: TestFilesCp_DagCborNodeFails (0.00s)
PASS
ok      github.com/ipfs/kubo/core/commands      0.029s

[gammazero]

@PsychoPunkSage I made 3 additional minor changes. See my 3 commits above.

[gammazero]

LGTM

[PsychoPunkSage]

Hi @gammazero
I have gone through the changes... Thanks
GTG

[PsychoPunkSage]

hi @lidel I think is PR is ready to be merged.
Please have a look at it

[lidel]

Thank you, mostly ok, but needs end-to-end tests + small nits inline.

[PsychoPunkSage]

Hi @lidel
I noticed an interesting behavior here...
This test reveals something important about your implementation - the --force flag skips the initial validation, but there's still a later step (flushing) that can't handle non-UnixFS node types.
filesCpCmd allows copying a non-UnixFS node with --force, but MFS itself might not be able to properly handle or flush that type of node, causing this error during the flush operation.

What should I do?? Maybe create another PR to handle the Flush thing....
Adding the Flush here will make this PR quite big ig.

[lidel]

Discussed this during triage today, and the consensus is to remove --force flag.

We don't have time to go intoo rabbit hole of fleshing out specs for MFS that supports codecs other than UnixfS( dag-pb and raw).

We don't want this actually, because MFS data model is files and directories (which could be mounted over something like FUSE in the future).

This formally limits ipfs files API to files and directories (unixfs).
If someone wants to mix UnixFS with other codecs (like dag-cbor) they can use lower level API at ipfs dag.

@PsychoPunkSage so the ask is to remove --force from this PR 🙏

[lidel]

Disregard, I'm going to do it :)

[lidel]

Thank you, we will include this in Kubo 0.34.0-rc1