fix(rpc): restore and deprecate bitswap reprovide#10699
Merged
Conversation
#10677 removed command without properly deprecating it first, this restores it and marks as deprecated we can remove it after at least 1 release with deprecation being announced
lidel
changed the title
bitswap reprovidebitswap reprovide
gammazero
approved these changes
Feb 6, 2025
guillaumemichel
approved these changes
Feb 6, 2025
Contributor
guillaumemichel
left a comment
guillaumemichel
left a comment
There was a problem hiding this comment.
Sorry about missing the deprecation, LGTM now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10677 removed command without properly deprecating it first, this restores it and marks as deprecated
without this, we would break every user who manually calls removed
bitswap reprovidevia their croncc @guillaumemichel and @gsergey418alt for visibility – in the future make sure we keep old command working and deprecate it first, we can remove it after at least 1 release with deprecation being announced 🙏
Closes #10387