-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pebbleds profile and plugin #10530
Conversation
Pebble provides a high-performance alternative to leveldb as the datastore, and will serve as a replacement for badger1. There are a number of tuning parameters available for tuning pebble's performance to your specific needs. Default values are used for any that are not configured or are set to the parameter's zero-value. Requires ipfs/go-ds-pebble#39 Closes #10347
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, pushed some extra docs and e2e test for all three datastore profiles
i think the only remaining topic here is if we should hardcode zero values in config
– see the idea inline in init.go
Co-authored-by: Marcin Rataj <[email protected]>
Co-authored-by: Marcin Rataj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, let's include it in 0.31.0-rc1 👍
go.mod
Outdated
@@ -28,6 +29,7 @@ require ( | |||
github.com/ipfs/go-ds-flatfs v0.5.1 | |||
github.com/ipfs/go-ds-leveldb v0.5.0 | |||
github.com/ipfs/go-ds-measure v0.2.0 | |||
github.com/ipfs/go-ds-pebble v0.3.2-0.20241002075519-c174835dc84a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gammazero mind releasing go-ds-pebble and switch to release here before merging this PR?
Pebble provides a high-performance alternative to leveldb as the datastore, and will serve as a replacement for badger1.
There are a number of tuning parameters available for tuning pebble's performance to your specific needs. Default values are used for any parameters that are not configured or are set to their zero-value.
Requires ipfs/go-ds-pebble#39
Closes #10347