ipfs add with onlyhash, memery high usage

[hcg1314]

Version information:

go-ipfs version: 0.4.22-
Repo version: 7
System version: amd64/linux
Golang version: go1.12.7

Description:

The VM has 8GB of RAM.
My application will generate a lots of calls ipfs add -n with a speed 40 per seonds.
Firstly, the ipfs daemon just cost little memery. however, one hours later, out of memery.
If stop my application, the ipfs will return to normal after a few hours.

i want to know, is there a way to reduce recovery time? thanks!

here is the data collected by bin/collect-profiles.sh

[hcg1314]

when i add defer nilnode.Peerstore.Close() in core/coreapi/unixfs.go，the MEM% grow up slower

[Stebalien]

@hcg1314 what if you add defer nilnode.Close()? #6744

[hcg1314]

@hcg1314 what if you add defer nilnode.Close()? #6744

If add defer nilnode.Close(), seems like can not release Peerstore.
I have tested it in this way:

I add log.Info("I'm stopped!") in vendor/github.com/libp2p/go-libp2p-peerstore/pstoremem/addr_book.go, function: func (mab *memoryAddrBook) background() {}
when the ipfs add -n xxx is over, i'm stopped! appears.
But, if i add defer nilnode.Close(), i'm stopped! does not appear.

[Stebalien]

What if you add both? I'm trying to figure out "the MEM% grow up slower".

There's a bug in go-ipfs 0.4.22 where we don't close the peerstore when the node is closed. This has been fixed in master.

[hcg1314]

'master' branch has fix this issue