Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs pin update $cid $cid removes pin #6648

Closed
bmwiedemann opened this issue Sep 17, 2019 · 0 comments · Fixed by #6669
Closed

ipfs pin update $cid $cid removes pin #6648

bmwiedemann opened this issue Sep 17, 2019 · 0 comments · Fixed by #6669
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@bmwiedemann
Copy link
Contributor

Version information:

go-ipfs version: 0.4.22-
Repo version: 7
System version: amd64/linux
Golang version: go1.12.7

Description:

requesting a pin update to the same CID, unpins the CID

Steps to reproduce:

cid=bafkreiebo74xkezbgutn6lhwdbgy76mgyz227niu2ttiuqcacbjbxcagim
ipfs pin add $cid
ipfs pin ls --type=recursive | grep $cid
ipfs pin update $cid $cid
ipfs pin ls --type=recursive | grep $cid

I accidentally found this when implementing an ipfsfollow shell script to track the latest version of my /ipns/opensuse.zq1.de on a backup machine.
@bmwiedemann bmwiedemann added the kind/bug A bug in existing code (including security flaws) label Sep 17, 2019
Stebalien added a commit that referenced this issue Sep 23, 2019
@Stebalien
pin: fix pin update X Y where X==Y
6722a38 
We were pining Y then removing the pin for X. When X == Y, we'd remove the new
pin.

fixes #6648
@Stebalien Stebalien mentioned this issue Sep 23, 2019
Merged
Stebalien added a commit that referenced this issue Jan 17, 2020
@Stebalien
pin: fix pin update X Y where X==Y
5289fd3 
We were pining Y then removing the pin for X. When X == Y, we'd remove the new
pin.

fixes #6648
Stebalien added a commit that referenced this issue Jan 17, 2020
@Stebalien
pin: fix pin update X Y where X==Y
4673dbf 
We were pining Y then removing the pin for X. When X == Y, we'd remove the new
pin.

fixes #6648
Stebalien added a commit that referenced this issue Jan 17, 2020
@Stebalien
pin: fix pin update X Y where X==Y
c69e347 
We were pining Y then removing the pin for X. When X == Y, we'd remove the new
pin.

fixes #6648
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
@Stebalien
pin: fix pin update X Y where X==Y
ed329ca 
We were pining Y then removing the pin for X. When X == Y, we'd remove the new
pin.

fixes ipfs#6648
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
@Stebalien
pin: fix pin update X Y where X==Y
c75fb6b 
We were pining Y then removing the pin for X. When X == Y, we'd remove the new
pin.

fixes ipfs#6648
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
pin: fix pin update X Y where X==Y
7d0569e 
We were pining Y then removing the pin for X. When X == Y, we'd remove the new
pin.

fixes ipfs#6648
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
pin: fix pin update X Y where X==Y
4c4165b 
We were pining Y then removing the pin for X. When X == Y, we'd remove the new
pin.

fixes ipfs#6648
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
pin: fix pin update X Y where X==Y
e73a408 
We were pining Y then removing the pin for X. When X == Y, we'd remove the new
pin.

fixes ipfs#6648
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
pin: fix pin update X Y where X==Y
d18f1c0 
We were pining Y then removing the pin for X. When X == Y, we'd remove the new
pin.

fixes ipfs#6648
@Kycklingar Kycklingar mentioned this issue Oct 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pin: fix pin update X Y where X==Y ipfs/kubo
1 participant
@bmwiedemann