Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(importer) Implement Rabin Fingerprinting #56

Closed
whyrusleeping opened this issue Sep 12, 2014 · 2 comments
Closed

feat(importer) Implement Rabin Fingerprinting #56

whyrusleeping opened this issue Sep 12, 2014 · 2 comments
Assignees
@whyrusleeping
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@whyrusleeping
Copy link
Member

Our current file chunking scheme is just splitting on blocks of a certain size. This is bad for a variety of reasons. @jbenet and I think it will be best to use rabin fingerprinting as our default method for file chunking. The downside is that, other than a brief description on wikipedia, there isnt much to go on for the algorithm itself, so its gonna be a bit of fun figuring this out.
@whyrusleeping whyrusleeping added kind/enhancement A net-new feature or improvement to an existing feature ready labels Sep 12, 2014
@whyrusleeping whyrusleeping changed the title Implement Rabin Fingerprinting feat(importer) Implement Rabin Fingerprinting Sep 13, 2014
@whyrusleeping whyrusleeping self-assigned this Sep 14, 2014
@btc
Copy link
Contributor

btc commented Sep 24, 2014

Is there an open PR/branch associated with this?

@btc btc added status/in-progress In progress and removed codereview labels Sep 24, 2014
@whyrusleeping
Copy link
Member Author

uhm... i beleive its in master at this point, called 'MaybeRabin' in importer/rabin.go (calling it maybeRabin because i need someone else to verify that the algorithm is correct. (Although it appears to work as expected)

@whyrusleeping whyrusleeping removed the status/in-progress In progress label Oct 6, 2014
@aschmahmann aschmahmann mentioned this issue Sep 22, 2020
Closed
72 tasks
longfeiWan9 pushed a commit to longfeiWan9/go-ipfs that referenced this issue Nov 18, 2021
@lidel
Merge pull request ipfs#56 from ipfs/fix/disable-i18n-for-cids
67e75cd 
* fix: disable translation of cids
* fix: explicit language of the document
@aschmahmann aschmahmann mentioned this issue Dec 1, 2021
Closed
80 tasks
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Feb 25, 2022
@Stebalien
Merge pull request ipfs#56 from ipfs/dependabot/go_modules/github.com…
791dbf1 
…/libp2p/go-libp2p-core-0.2.5

Bump github.com/libp2p/go-libp2p-core from 0.2.3 to 0.2.5
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Feb 25, 2022
@Stebalien
go-ipfs-config: Merge pull request ipfs#56 from ipfs/dependabot/go_mo…
37002b5 
…dules/github.com/libp2p/go-libp2p-core-0.2.5

Bump github.com/libp2p/go-libp2p-core from 0.2.3 to 0.2.5
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Apr 7, 2022
@Stebalien
Merge pull request ipfs#56 from ipfs/fix/make-session
a8d50ff 
fix: correctly construct sessions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whyrusleeping whyrusleeping

Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@btc @whyrusleeping