Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the new iptb #5521

Closed
Stebalien opened this issue Sep 25, 2018 · 7 comments
Closed

Switch to the new iptb #5521

Stebalien opened this issue Sep 25, 2018 · 7 comments
Labels
kind/test Testing work

Comments

@Stebalien
Copy link
Member

We have a new iptb version with a changed API. Somebody needs to go through and update all invocations of iptb in our test cases to use this new API.

@Stebalien Stebalien added the kind/test Testing work label Sep 25, 2018
@Stebalien
Copy link
Member Author

@ipfs/go-team who wants this? It's not exactly a glorious task but we need to get it done.

@bigs
Copy link
Contributor

bigs commented Sep 25, 2018

commenting to follow this issue, as i'll be doing similar stuff for libp2p

@Stebalien
Copy link
Member Author

@travisperson I know you're busy, but could you make this happen? We have to cut an off-master point release of iptb every time we release because we're stuck on 1.0.

@travisperson
Copy link
Member

@Stebalien Ya I can update this. I have a branch that has most of the sharness tests updated already from a while back. Let me rebase it, update anything new and I'll open a PR.

@Stebalien
Copy link
Member Author

Awesome! Doesn't that depend on ipfs/iptb#91?

@eingenito eingenito added the status/ready Ready to be worked label Oct 2, 2018
@travisperson
Copy link
Member

Yes. Down the road I want to move the plugins out of the main iptb project. At the moment thought that is a bit difficult due to packages conflicting due to gx. That should be fixed this quarter though so for now they will stay there.

travisperson pushed a commit that referenced this issue Oct 23, 2018
travisperson pushed a commit that referenced this issue Oct 23, 2018
Related to #5521

License: MIT
Signed-off-by: Travis Person <[email protected]>
travisperson pushed a commit that referenced this issue Nov 2, 2018
Related to #5521

License: MIT
Signed-off-by: Travis Person <[email protected]>
@travisperson
Copy link
Member

Fixed in #5636

@ghost ghost removed the status/ready Ready to be worked label Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/test Testing work
Projects
None yet
Development

No branches or pull requests

4 participants