-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.4.14-rcX fails js-ipfs-api test suite #4818
Comments
I've done few more runs: On 0.4.13: On 0.4.14-rc2 |
@victorbjelkholm @diasdavid could we get some help interpreting these. I see that there are some that are false positive lookalike. Like the |
Changes I see:
and with --with-local:
|
Try with https://github.com/ipfs/js-ipfs-api/releases/tag/v18.1.2 test suite. Currently js-ipfs-api Master is in flux due to many Windows + other fixes that were happening in parallel and complicating things, next week it will be golden again. |
Tried with js-ipfs-api 18.1.2 + go-ipfs 0.4.14-rc2, fails mostly in the same ways as the master: https://hastebin.com/gigiforudu.vbs |
@victorbjelkholm can we get some automated CI for running js-ipfs-api tests? |
For 0.4.13 / js-api 18.1.2 there is only a single test failing, prorbaly a random fail: https://hastebin.com/eticutoyal.vbs |
I tried to find a difference between files/stat on 0.4.13 and 0.4.14-rc2: 0.4.14-rc2:
go-ipfs/0.4.13:
The only difference is the removed |
Looked into the test failures from js-ipfs-api v18.1.2 with go-ipfs 0.4.14-rc2
|
Seems like It is introduced in It is controlled by https://github.com/ipfs/go-ipfs-cmds/blob/master/responseemitter.go#L10-L14 and our mistake is not using EmitOnce or From another side, sending even chunked response with single chunk should not break the js-ipfs-api. I am fixing this but please harden js-ipfs-api parsing. |
Part of #4818 License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Regarding pubsub, this is what I see when testing $ ipfs daemon --enable-pubsub-experiment # in one terminal
$ ipfs pubsub sub test # in another terminal
$ ipfs pubsub ls # in yet another terminal, but gives output:
Error: not of type error |
Fixed |
So with @Kubuxu's fixes, I've been able to get green tests for node tests on js-ipfs-api. This is the only change required on js-ipfs-api's side: ipfs-inactive/js-ipfs-http-client#718 Currently running browser+webworker tests, but should be fine.
|
So, seems like the tests are all passing with 90017e9 and ipfs-inactive/js-ipfs-http-client#718, even in the browser and webworker. Great work @Kubuxu for quick fixes and @magik6k for debugging awesomeness! 👍 |
Part of ipfs#4818 License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
This is resolved now |
Reference ipfs-inactive/js-ipfs-http-client#486 (comment)
Test output: https://friendpaste.com/72TbssZSoSxmdOpKxT67je
The text was updated successfully, but these errors were encountered: