Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: makefile doesn't understand path quirk #2833

Closed
djdv opened this issue Jun 10, 2016 · 4 comments
Closed

Windows: makefile doesn't understand path quirk #2833

djdv opened this issue Jun 10, 2016 · 4 comments
Labels
regression topic/tools Topic tools topic/windows Windows specific

Comments

@djdv
Copy link
Contributor

djdv commented Jun 10, 2016 •
edited
Loading

Previously I have used make from the msys2 project inside of a native Windows command line shell to build IPFS, pull #2808 seems to have broken my ability to build this way. This is more than likely do to the way msys and cygwin convert Windows paths i.e. C:\tmp -> /c/tmp.

make break

Within an msys2 shell I can build again just fine after setting up Go paths, or installing a second copy of Go inside of the msys environment.

make break 2

I'm not sure how many people this effects but I don't think it's too uncommon for people to use the native shell and natively installed version of Go if they can.
@ghost ghost mentioned this issue Jun 13, 2016
Closed
@ghost
Copy link

ghost commented Jun 13, 2016

cc @kalabe got a good idea how to fix building on windows? If it's too tricky I think we should revert #2808 and instead reconsider how we're organizing our build.

@ghost ghost added kind/bug A bug in existing code (including security flaws) topic/windows Windows specific regression topic/tools Topic tools and removed kind/bug A bug in existing code (including security flaws) labels Jun 13, 2016
@djdv
Copy link
Contributor Author

djdv commented Jun 14, 2016

@lgierth I think @karalabe is the intended name, kalabe is someone else. Pinging for above.

ghost pushed a commit that referenced this issue Jun 17, 2016
Revert "Makefile, bin: Support multiple GOPATH components"
f6c62c7 
This reverts commit ff75bc0,
which broke building on windows. See #2833.
@ghost ghost mentioned this issue Jun 17, 2016
Merged
ghost pushed a commit that referenced this issue Jun 17, 2016
Revert "Makefile, bin: Support multiple GOPATH components"
ad461c6 
This reverts commit ff75bc0,
which broke building on windows. See #2833.

License: MIT
Signed-off-by: Lars Gierth <[email protected]>
kevina pushed a commit to ipfs-filestore/go-ipfs that referenced this issue Jun 20, 2016
@kevina
Revert "Makefile, bin: Support multiple GOPATH components"
4ebfd54 
This reverts commit ff75bc0,
which broke building on windows. See ipfs#2833.

License: MIT
Signed-off-by: Lars Gierth <[email protected]>
@Kubuxu
Copy link
Member

Kubuxu commented Jun 21, 2016

It was reverted, should we close it?

@djdv
Copy link
Contributor Author

djdv commented Jun 21, 2016

I would say yes, but a separate issue should probably be opened for multiple GOPATH paths if that's still desired.

@djdv djdv mentioned this issue Jul 6, 2016
Closed
@djdv djdv closed this as completed Jul 6, 2016
@djdv djdv mentioned this issue Jul 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression topic/tools Topic tools topic/windows Windows specific
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kubuxu @djdv