-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting "deep" config options doesn't work #1561
Comments
@ehd yeah, it should. interesting... can you repro with a test case? we should add it to test suite if so |
@jbenet Yeah, gladly. Should I add it in this test? I also found this test in user-config which sets a deep property successfully. Lo and behold, maybe a difference between One more question: Where do I put the ipfs binary in order to run the tests? From the README I couldn't find out how to build ipfs in a way that makes it work within the test harness command from |
@ehd yeah that test works.
just run |
This adds a failing for the case described in ipfs#1561
@jbenet seidtgeist@c6d1413 adds test cases for:
|
thanks @ehd! |
@rht, @whyrusleeping, @Heems can one of you pick this up this week? |
thanks! should i open a PR or something to get the above commit merged? |
@ehd uh huh |
@rht I opened a PR pulling my commit into your fork so master doesn't get a failing test merged in. Please let me know if you want me to do something else instead. |
This adds a failing for the case described in ipfs#1561
This adds a failing for the case described in ipfs#1561 License: MIT Signed-off-by: Stephan Seidt <[email protected]>
high 🙏🏻 five. Thank you. |
This adds a failing for the case described in ipfs#1561 License: MIT Signed-off-by: Stephan Seidt <[email protected]>
This adds a failing for the case described in ipfs#1561 License: MIT Signed-off-by: Stephan Seidt <[email protected]>
I consulted the new CORS documentation in
ipfs daemon --help
and found thisHowever, when I tried it I got an error at first.
Using
ipfs config show
I saw thatAPI.HTTPHeaders
is set tonull
, so I set it to an empty object like this:Afterwards I was also able set properties within the
API.HTTPHeaders
object.I would have expected the
ipfs config --json
command to automatically create objects along a valid property path.The text was updated successfully, but these errors were encountered: