Skip to content

Commit

Permalink
coreapi: dag: Missing batch docs
Browse files Browse the repository at this point in the history
License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
  • Loading branch information
magik6k committed Aug 3, 2018
1 parent 9f22058 commit d6ee955
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
5 changes: 5 additions & 0 deletions core/coreapi/dag.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,14 @@ func (api *DagAPI) Tree(ctx context.Context, p coreiface.Path, opts ...caopts.Da
return out, nil
}

// Batch creates new DagBatch
func (api *DagAPI) Batch(ctx context.Context) coreiface.DagBatch {
return &dagBatch{api: api}
}

// Put inserts data using specified format and input encoding. Unless used with
// `WithCodes` or `WithHash`, the defaults "dag-cbor" and "sha256" are used.
// Returns the path of the inserted data.
func (b *dagBatch) Put(ctx context.Context, src io.Reader, opts ...caopts.DagPutOption) (coreiface.ResolvedPath, error) {
nd, err := getNode(src, opts...)
if err != nil {
Expand All @@ -84,6 +88,7 @@ func (b *dagBatch) Put(ctx context.Context, src io.Reader, opts ...caopts.DagPut
return coreiface.IpldPath(nd.Cid()), nil
}

// Commit commits nodes to the datastore and announces them to the network
func (b *dagBatch) Commit(ctx context.Context) error {
b.lk.Lock()
defer b.lk.Unlock()
Expand Down
2 changes: 1 addition & 1 deletion core/coreapi/dag_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ func TestBatch(t *testing.T) {
}

_, err = api.Dag().Get(ctx, c)
if err == nil || err.Error() != "merkledag: not found"{
if err == nil || err.Error() != "merkledag: not found" {
t.Error(err)
}

Expand Down
2 changes: 2 additions & 0 deletions core/coreapi/interface/dag.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ type DagOps interface {
type DagBatch interface {
DagOps

// Commit commits nodes to the datastore and announces them to the network
Commit(ctx context.Context) error
}

Expand All @@ -35,5 +36,6 @@ type DagAPI interface {
// Tree returns list of paths within a node specified by the path.
Tree(ctx context.Context, path Path, opts ...options.DagTreeOption) ([]Path, error)

// Batch creates new DagBatch
Batch(ctx context.Context) DagBatch
}

0 comments on commit d6ee955

Please sign in to comment.