gateway: label get requests latency with the path namespace

ipfs · Jun 5, 2019 · d460150 · d460150
1 parent ebd89b4
commit d460150
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/core/corehttp/gateway_handler.go b/core/corehttp/gateway_handler.go
@@ -173,7 +173,8 @@ func (i *gatewayHandler) getOrHeadHandler(w http.ResponseWriter, r *http.Request
 		webError(w, "ipfs cat "+escapedURLPath, err, http.StatusNotFound)
 		return
 	}
-	unixfsGetMetric.Observe(time.Since(begin).Seconds())
+
+	unixfsGetMetric.WithLabelValues(parsedPath.Namespace()).Observe(time.Since(begin).Seconds())
 
 	defer dr.Close()
 

diff --git a/core/corehttp/metrics.go b/core/corehttp/metrics.go
@@ -98,12 +98,12 @@ var (
 		prometheus.BuildFQName("ipfs", "p2p", "peers_total"),
 		"Number of connected peers", []string{"transport"}, nil)
 
-	unixfsGetMetric = prometheus.NewSummary(prometheus.SummaryOpts{
+	unixfsGetMetric = prometheus.NewSummaryVec(prometheus.SummaryOpts{
 		Namespace: "ipfs",
 		Subsystem: "http",
 		Name:      "unixfs_get_latency_seconds",
 		Help:      "The time till the first block is received when 'getting' a file from the gateway.",
-	})
+	}, []string{"namespace"})
 )
 
 type IpfsNodeCollector struct {