Skip to content

Commit

Permalink
ci: trigger continuation on tags (#8466)
Browse files Browse the repository at this point in the history
When the config was wrapped in a continuation so that params could be
dynamically generated, this broke tag workflows since there was no
explicit tag filter anymore in config.yml. This attempts to fix that.

I may have gotten this wrong, since this is intrinsically hard to
test. We'll see next time we tag something.
  • Loading branch information
guseggert authored Sep 28, 2021
1 parent 485a5c2 commit 731b4de
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
14 changes: 14 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@ version: 2.1
setup: true
orbs:
continuation: circleci/[email protected]

aliases:
only-version-tags: &only-version-tags
tags:
only: /^v[0-9].*/
branches:
ignore: /.*/

jobs:
generate-params:
executor: continuation/default
Expand Down Expand Up @@ -35,3 +43,9 @@ workflows:
setup-workflow:
jobs:
- generate-params

# NOTE: CircleCI only builds tags if you explicitly filter for them.
setup-workflow-tag:
jobs:
- generate-params:
filters: *only-version-tags
1 change: 0 additions & 1 deletion .circleci/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,6 @@ workflows:
# the bifrost-* branches are used for deploying code that hasn't hit master yet (e.g. for testing)
- /^bifrost-.*/


# NOTE: CircleCI only builds tags if you explicitly filter for them. That
# also means tag-based jobs can only depend on other tag-based jobs, so we
# use a separate workflow because every job needs to be tagged together.
Expand Down

0 comments on commit 731b4de

Please sign in to comment.