fix: pubsub flag defaults#363
Merged
Merged
Conversation
3 tasks
vasco-santos
force-pushed
the
fix/pubsub-flag-defaults
branch
from
697d3cd to
54dbc29
Compare
hugomrdias
approved these changes
Sep 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the context of ipfs/js-ipfs#2298#pullrequestreview-280953619, we are moving to
enable-pubsubinstead.enabledshould be a property of pubsub, in order to allow the usage of other options.This PR has a circular dependency issue with ipfs/js-ipfs#2298